Add support for parsing preformatted email addresses that include both name and address

[dormitionskete]

I recently became acquainted with SimpleJavaMail. I've been testing it for a few days, and so far, I like it very much. Thank you very much for making it, and sharing it with us!

On your website, you asked for suggestions for how it could be improved. I have a few "wishlist" items for it. I'll put them in separate tickets so you can evaluate and track them individually.

---

You currently have the ability to add multiple recipients with:

email.addRecipients("jsmith@somewhere.net, jsmith@nowhere.com", RecipientType.TO);

It'd be very much appreciated if you would extend its capabilities to accept entries such as:

email.addRecipients("\"John Smith\" <jsmith@somewhere.net>, \"Jane Doe\" <jsmith@nowhere.com>", RecipientType.TO);

[bbottema]

Release in 4.4.0. Please verify.

[dormitionskete]

It still won't build for me, so I can't verify it for you.

Tomorrow is Transfiguration, so I won't be able to work on it until Monday.

Forgive me, please.

I do very much appreciate you working on this.

cd /Users/frpeter/NetBeansProjects/simple-java-mail; JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home "/Applications/NetBeans/NetBeans 8.2.app/Contents/Resources/NetBeans/java/maven/bin/mvn" clean install
Scanning for projects...
simplejavamail.util.ConfigLoaderTest
15:54:49 [main] INFO  SMTPServer - SMTP server *:251 starting
15:54:49 [main] INFO  SMTPServer - SMTP server *:251 starting
Tests run: 3, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 4.468 sec <<< FAILURE! - in org.simplejavamail.mailer.MailerLiveTest
createMailSession_StandardDummyMail(org.simplejavamail.mailer.MailerLiveTest)  Time elapsed: 1.742 sec  <<< ERROR!
java.lang.RuntimeException: java.net.BindException: Permission denied
Caused by: java.net.BindException: Permission denied

createMailSession_OutlookMessageTest(org.simplejavamail.mailer.MailerLiveTest)  Time elapsed: 0.002 sec  <<< ERROR!
java.lang.RuntimeException: java.net.BindException: Permission denied
Caused by: java.net.BindException: Permission denied
---

[bbottema]

Hi @dormitionskete, no need to apologise! There's no hurry and you don't owe me anything. I'm just thankful for your helpful review of the API and suggestions to improve it.

Now for the error, it seems like a permission issue at your end. Travis is having no issues (runs fine for me as well of course), but when the MailerLiveTest runs it starts a dummy SMTP server, which fails for you on account of permissions.

Two things to note:

1. You're free to build manually of course, but I already released this feature in Maven (4.4.0). You can also directly download the jar from there if you want.
2. You can also temporarily set that test class to @Ignore, so the build skips the part where it tries to start the dummy SMTP server.

[dormitionskete]

Hello. I'm usually not such a nuisance, but this gives me a null pointer exception when I try to run it with the 4.4.0 jar downloaded from Maven, and with the 4.4.1-SNAPSHOT from GitHub, in projects run in both Netbeans and Eclipse.

I've changed the confidential info to dummy info, but otherwise, the following simple test code throws the exception at the "mailer.sendMail(email);" line.

            Email email = new Email();
            email.setFromAddress("Test Sender", "myemailaddress@mydomain.net");
            email.addRecipient("Test Recipient", "myrecipientemailaddress@somedomain.net", RecipientType.TO);
            email.setSubject("Test Message Subject");
            email.setText("Hello.\n\nThis is a test.");
            Mailer mailer = new Mailer("myserver.net", 25, "username", "password");
            mailer.sendMail(email);

It appears to be a problem on or around Line 400 of Mailer.java:

scanForInjectionAttack(email.getReplyToRecipient().getName(), "email.replyToRecipient.name");

By inserting the @ignore directive in your MailerLiveTest class, I was able to get simplejavamail to build with code from GitHub. So if you can fix it, I should be able to test it further for you.

Thank you for all of your patience with me.