Add :any parameter for query options #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightpool
commented
Feb 11, 2025
| ### Allow query params | ||
|
|
||
| ```ruby | ||
| stub_request(:get, "www.example.com").with(query: :any) |
There was a problem hiding this comment.
Even this usage still feels a little heavy-weight to me.... Is there any reason we can't do stub_request(:get, "www.example.com", query: :any)? Or even just make it the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and closes #877!
Implementation was very straightforward, the only doubt I had was the first parameter to
AnyArgMatcher. I'm not sure if thenilargument is necessary, since we explicitly ignore it. Feels like it would be better to make initialize allow a default value of nil. However, all of the existing usages of AnyArgMatcher also pass nil, so I held off on making that change for now to get some feedback on whether that change makes sense