Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error for Ruby 3.5 CI matrix #1097

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

koic
Copy link
Collaborator

@koic koic commented Feb 6, 2025

This is a workaround to resolve the following error in Ruby 3.5:

/home/runner/work/webmock/webmock/vendor/bundle/ruby/3.5.0+0/gems/ethon-0.16.0/lib/ethon.rb:2:
warning: logger was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.

It can likely be removed once `ethon`, which is a dependency of `typhoeus`, manages its `logger` dependency.

https://github.com/bblimke/webmock/actions/runs/13170758361/job/36760571749

This is a workaround to resolve the following error in Ruby 3.5:

```console
/home/runner/work/webmock/webmock/vendor/bundle/ruby/3.5.0+0/gems/ethon-0.16.0/lib/ethon.rb:2:
warning: logger was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.

It can likely be removed once `ethon`, which is a dependency of `typhoeus`, manages its `logger` dependency.
```

https://github.com/bblimke/webmock/actions/runs/13170758361/job/36760571749
@koic koic force-pushed the fix_build_error_in_ruby_3_5_ci_matrix branch from 5289063 to 1e7e9df Compare February 6, 2025 03:21
@koic koic merged commit cb65c87 into bblimke:master Feb 6, 2025
8 of 9 checks passed
@koic koic deleted the fix_build_error_in_ruby_3_5_ci_matrix branch February 6, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant