TSGuild-99: Create a TypeScript version of election-api-javascript #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2023 12:26
This commit creates the skeleton application of election-api-javascript in a TypeScript environment.
… files Added Jest configuration for TypeScript support and copied JSON test files from election-api-javascript.
rossanodan
commented
Jun 2, 2023
paulbrimicombe
approved these changes
Jun 16, 2023
Co-authored-by: Allan Mckinlay <122284042+amckinlaybbc@users.noreply.github.com>
Co-authored-by: Paul Douglas Brimicombe <paul.brimicombe@bbc.co.uk>
Co-authored-by: Paul Douglas Brimicombe <paul.brimicombe@bbc.co.uk>
Co-authored-by: Paul Douglas Brimicombe <paul.brimicombe@bbc.co.uk>
…the store As per comment, I'm returning null to rely on a message that indicates the new data has been created successfully.
Result | null was incompatible with the result type of the function.
Co-authored-by: Paul Douglas Brimicombe <paul.brimicombe@bbc.co.uk>
amckinlaybbc
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request adds a new project to the list,
election-api-typescript. This is an exact copy ofelection-api-javascriptwith the only difference that the development environment is based on TypeScript.Why?
This will help recruitment to test candidates' TypeScript capabilities and it will also give more choice to the candidates who prefer writing TypeScript code.
Next steps
Create
election-ui-typescript@bbc/typescript-guild