Derive image mime type from srcset #9751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
added
cross-team
amoore108
changed the title
ryanmccombe
reviewed
Dec 16, 2021
| export const getMimeType = srcset => { | ||
| if (!srcset) return null; | ||
|
|
||
| const [firstSrcset] = srcset?.split(','); |
There was a problem hiding this comment.
I believe the ?. is in the wrong place here? srcset is always defined (because of line 6).
I think the only scenario this function can throw an exception is that if srcset is not a string - in which case split would not be defined
Although updating line 6 to catch that is probably cleaner than optional chaining
andrewscfc
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9628
Overall change:
Adds logic to derived the mime-type of image srcsets. This allows older browsers to know what the image format of the srcset should be if they can't derive it from the server response
Code changes:
createSrcsetsfunction to return mime-types for the primary and fallback srcset values. These get passed through to thepsammead-imagecomponent and get set on the<source />elementsEnabled by: BBC-archive/psammead#4608
cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)