Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Updates #8406

Merged
merged 31 commits into from
Nov 23, 2020
Merged

Dependency Updates #8406

merged 31 commits into from
Nov 23, 2020

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Nov 18, 2020 •
edited
Loading

Overall changes:

Miscellaneous

Babel & Webpack

Testing Libraries

  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@dependabot @karinathomasbbc
Bump jest-junit from 11.1.0 to 12.0.0
b0175a6 
Bumps [jest-junit](https://github.com/jest-community/jest-junit) from 11.1.0 to 12.0.0.
- [Release notes](https://github.com/jest-community/jest-junit/releases)
- [Commits](jest-community/jest-junit@v11.1.0...v12.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc karinathomasbbc added this to the Dependency Updates milestone Nov 18, 2020
@karinathomasbbc karinathomasbbc self-assigned this Nov 18, 2020
dependabot bot and others added 19 commits November 18, 2020 18:29
@dependabot @karinathomasbbc
Bump supertest from 4.0.2 to 6.0.1
ed8d771 
Bumps [supertest](https://github.com/visionmedia/supertest) from 4.0.2 to 6.0.1.
- [Release notes](https://github.com/visionmedia/supertest/releases)
- [Commits](ladjs/supertest@v4.0.2...v6.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump copy-webpack-plugin from 6.3.0 to 6.3.1
36969e1 
Bumps [copy-webpack-plugin](https://github.com/webpack-contrib/copy-webpack-plugin) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/webpack-contrib/copy-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/copy-webpack-plugin@v6.3.0...v6.3.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump cypress from 5.5.0 to 5.6.0
d47684d 
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](cypress-io/cypress@v5.5.0...v5.6.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump compression-webpack-plugin from 6.1.0 to 6.1.1
84014e2 
Bumps [compression-webpack-plugin](https://github.com/webpack-contrib/compression-webpack-plugin) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/webpack-contrib/compression-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/compression-webpack-plugin@v6.1.0...v6.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump jest-silent-reporter from 0.2.1 to 0.3.0
5b8d64f 
Bumps [jest-silent-reporter](https://github.com/rickhanlonii/jest-silent-reporter) from 0.2.1 to 0.3.0.
- [Release notes](https://github.com/rickhanlonii/jest-silent-reporter/releases)
- [Commits](https://github.com/rickhanlonii/jest-silent-reporter/commits)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @storybook/addon-knobs from 5.3.21 to 6.0.28
58b1d80 
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 5.3.21 to 6.0.28.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.28/addons/knobs)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc
Merge branch 'latest' into 2020-11-18-dependencies
6e35101
@dependabot @karinathomasbbc
Bump @storybook/theming from 5.3.21 to 6.0.28
3c19f60 
Bumps [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/lib/theming) from 5.3.21 to 6.0.28.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.28/lib/theming)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc
Merge branch '2020-11-18-dependencies' of github.com:bbc/simorgh into…
32c5197 
… 2020-11-18-dependencies
@dependabot @karinathomasbbc
Bump webpack-bundle-analyzer from 3.9.0 to 4.1.0
0621af9 
Bumps [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer) from 3.9.0 to 4.1.0.
- [Release notes](https://github.com/webpack-contrib/webpack-bundle-analyzer/releases)
- [Changelog](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/webpack-bundle-analyzer/commits/v4.1.0)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc
Merge branch 'latest' into 2020-11-18-dependencies
00dfc98
@dependabot @karinathomasbbc
Bump moment-timezone from 0.5.31 to 0.5.32
3116749 
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.31 to 0.5.32.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](moment/moment-timezone@0.5.31...0.5.32)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc
Merge branch '2020-11-18-dependencies' of github.com:bbc/simorgh into…
f9c7fd3 
… 2020-11-18-dependencies
@karinathomasbbc
Force resolutions? 🤷‍♀️
44fc0b4
@dependabot @karinathomasbbc
Bump webpack-merge from 5.3.0 to 5.4.0
37629d8 
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md)
- [Commits](survivejs/webpack-merge@v5.3.0...v5.4.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @testing-library/react from 11.1.1 to 11.2.1
7528184 
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.1.1 to 11.2.1.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.1.1...v11.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @testing-library/jest-dom from 5.11.5 to 5.11.6
6c6c30e 
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.11.5 to 5.11.6.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/master/CHANGELOG.md)
- [Commits](testing-library/jest-dom@v5.11.5...v5.11.6)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump babel-loader from 8.1.0 to 8.2.1
a381db8 
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.1.0 to 8.2.1.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.1.0...v8.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @testing-library/dom from 7.26.5 to 7.26.6
6f3b948 
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.26.5 to 7.26.6.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/dom-testing-library@v7.26.5...v7.26.6)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc karinathomasbbc added the cross-team For visibility for both World Service teams (Engage & Media) label Nov 19, 2020
RichardPK
RichardPK reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@RichardPK RichardPK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those Storybook bumps will break it in Simorgh!

It'll need the v6 migration treatment 😬 : BBC-archive/psammead#3728

@karinathomasbbc
Copy link
Contributor Author

Those Storybook bumps will break it in Simorgh!

It'll need the v6 migration treatment 😬 : bbc/psammead#3728

😬 good spot, I didn't even think. Let me remove the storybook PRs from here, and we'll deal with them separately

@RichardPK
Copy link
Contributor

😬 good spot, I didn't even think. Let me remove the storybook PRs from here, and we'll deal with them separately

Is there a chance the other major ver bumps could also have breaking changes? webpack-bundle-analyzer jest-junit & supertest

@karinathomasbbc
Copy link
Contributor Author

karinathomasbbc commented Nov 20, 2020 •
edited
Loading

😬 good spot, I didn't even think. Let me remove the storybook PRs from here, and we'll deal with them separately

Is there a chance the other major ver bumps could also have breaking changes? webpack-bundle-analyzer jest-junit & supertest

My thoughts are:
Passing bundle tests + integration tests prove that webpack-bundle-analyzer is 👍
Passing unit + integration tests prove that jest-junit & supertest is 👍

@RichardPK
Copy link
Contributor

My thoughts are:
Passing bundle tests + integration tests prove that webpack-bundle-analyzer is 👍
Passing unit + integration tests prove that jest-junit & supertest is 👍

Yea that sounds like a very reasonable hypothesis!

karinathomasbbc and others added 9 commits November 23, 2020 09:21
@karinathomasbbc
Merge branch 'latest' of github.com:bbc/simorgh into 2020-11-18-depen…
e4dec0f 
…dencies
@dependabot @karinathomasbbc
Bump @testing-library/dom from 7.28.0 to 7.28.1
89c6e4a 
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.28.0 to 7.28.1.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/dom-testing-library@v7.28.0...v7.28.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump eslint from 7.13.0 to 7.14.0
b19e7ec 
Bumps [eslint](https://github.com/eslint/eslint) from 7.13.0 to 7.14.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.13.0...v7.14.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @testing-library/react from 11.2.1 to 11.2.2
38bae01 
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.2.1 to 11.2.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.2.1...v11.2.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @babel/preset-env from 7.12.1 to 7.12.7
8f72e6f 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.1 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump fetch-mock from 9.10.7 to 9.11.0
9c6f74d 
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.10.7 to 9.11.0.
- [Release notes](https://github.com/wheresrhys/fetch-mock/releases)
- [Commits](wheresrhys/fetch-mock@v9.10.7...v9.11.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @babel/core from 7.12.3 to 7.12.7
76dbda0 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @karinathomasbbc
Bump @babel/preset-react from 7.12.5 to 7.12.7
cb938a6 
Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.12.5 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-preset-react)

Signed-off-by: dependabot[bot] <support@github.com>
@karinathomasbbc
Merge branch 'latest' into 2020-11-18-dependencies
d24f677
@andrewscfc andrewscfc merged commit 37754fc into latest Nov 23, 2020
@andrewscfc andrewscfc deleted the 2020-11-18-dependencies branch November 23, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardPK RichardPK RichardPK left review comments

@jroebu14 jroebu14 jroebu14 approved these changes

@andrewscfc andrewscfc andrewscfc approved these changes

Assignees

@karinathomasbbc karinathomasbbc

Labels
cross-team For visibility for both World Service teams (Engage & Media) dependencies
Projects
None yet
Milestone
Dependency Updates
Development

Successfully merging this pull request may close these issues.
4 participants
@karinathomasbbc @RichardPK @jroebu14 @andrewscfc