Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoise live radio and CPS pages on asset ID #5840

Merged
merged 7 commits into from
Mar 17, 2020

Conversation

ryanmccombe
Copy link
Contributor

Resolves #5528

Note: this also requires bumping a psammead component once available: BBC-archive/psammead#3238

This is largely cherry picked from @jroebu14 's PR here: #5523

Overall change:
Do not rerender the top level CPS and live radio pages if the asset ID hasn't changed.

Code changes:

  • Memoise components on asset ID

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@ryanmccombe ryanmccombe self-assigned this Mar 11, 2020
@ryanmccombe ryanmccombe marked this pull request as ready for review March 17, 2020 18:12
@ryanmccombe ryanmccombe merged commit b6ca33d into latest Mar 17, 2020
@ryanmccombe ryanmccombe deleted the memo-live-radio-and-cps-page branch March 17, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Player reloads when using skip to content
3 participants