Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service name in e2e #5051

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

AlistairGempf
Copy link
Contributor

@AlistairGempf AlistairGempf commented Jan 7, 2020

Resolves #NUMBER

Overall change:
Use service name (eg serbian) in e2e rather than test service (eg serbianCyr)

Code changes:

  • Destructure test config object to give the service name.

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@AlistairGempf
Copy link
Contributor Author

All the Jenkins failures are e2es failing because CypressError: Timed out retrying: Expected to find element: 'a[class^="SkipLink"]', but never found it. This is being fixed separately in #4948.

@AlistairGempf AlistairGempf merged commit be02f30 into integrate-new-navigation Jan 8, 2020
@AlistairGempf AlistairGempf deleted the e2e-test-service-name branch January 8, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants