Adding a Cypress test for the amp-img #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbrumpton
added
blocked
|
I've put the blocked label onto this until #1153 has been merged as this test will fail otherwise. |
dr3
previously approved these changes
Jan 14, 2019
cypress/integration/ampSpec.js
Outdated
| const figure = getElement('figure').eq(0); | ||
| figure.should('be.visible'); | ||
| figure.within(() => { | ||
| getElement('amp-img'); |
There was a problem hiding this comment.
Hmmm does this make an assertion? getElement('amp-img') could return null but as we're not checking its value, the tests would pass.
Suggested change
| getElement('amp-img'); | |
| getElement('amp-img').should('be.visible'); |
|
No longer blocked on #953. |
bcmn
removed
the
blocked
dr3
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #953
This adds a Cypress test to make sure that the image that is rendered on the page is an
amp-img.