Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress test to ensure component appears when guidance text is present #4580

Closed
1 task
PriyaKR opened this issue Nov 6, 2019 · 3 comments
Closed
1 task
Assignees
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team ws-media World Service Media

Comments

@PriyaKR
Copy link
Contributor

PriyaKR commented Nov 6, 2019

Is your feature request related to a problem? Please describe.
As a result of guidance text being added to media player in psammead in this issue #3139 we need to add cypress tests to ensure the component renders when there is a guidance text.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@PriyaKR PriyaKR added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team simorgh-core-stream ws-media World Service Media labels Nov 6, 2019
@PriyaKR PriyaKR self-assigned this Nov 6, 2019
@PriyaKR
Copy link
Contributor Author

PriyaKR commented Nov 6, 2019

Blocked until the psammead media player in simorgh is bumped to version 2.2.0

@rhenshaw56
Copy link
Contributor

@PriyaKR this would be a duplicate of #4253

@PriyaKR
Copy link
Contributor Author

PriyaKR commented Nov 6, 2019

Closing as its a duplicate.

@PriyaKR PriyaKR closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
None yet
Development

No branches or pull requests

2 participants