Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV: Add guidance to media placeholder image #3139

Closed
12 opened this issue Aug 14, 2019 · 3 comments · Fixed by BBC-archive/psammead#2517
Closed

AV: Add guidance to media placeholder image #3139

12 opened this issue Aug 14, 2019 · 3 comments · Fixed by BBC-archive/psammead#2517
Assignees
Labels
articles-av-epic Current focus for the articles features stream ws-articles Tasks for the WS Articles Team

Comments

@12
Copy link
Contributor

12 commented Aug 14, 2019

Is your feature request related to a problem? Please describe.
We need to add guidance messages to the placeholder images for media assets.

Describe the solution you'd like
As we have the entire aresMedia block to our disposal, we know if a media asset comes with guidance messages. This means that we should easily be able to add the guidance messages to our placeholder image, with our UX spec (including the screen reader UX) in mind.

image

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
This will require an a11y swarm once the logic is ready/available. This will require cross-browser testing to make sure there's no overlapping UI. We will implement Cypress tests to make sure the component appears if there is a guidance message.

Dev insight: Snapshots, Cypress tests to ensure the component is visible when a video block has a guidance message.

Additional context
Guidance/Warnings: The terminology is confusing because different systems use the opposite names for each thing. We should use what Ares calls warnings.short in the field SMP calls guidance

  • SMP guidance is things like This video contains swears
  • SMP warnings are things like This video has no sound
  • SMP warnings are a nice to have that MPV and Ares doesn't currently support.
@12 12 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-av-epic Current focus for the articles features stream labels Aug 14, 2019
@HarveyPeachey HarveyPeachey removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Aug 21, 2019
@rhenshaw56 rhenshaw56 self-assigned this Oct 24, 2019
@lizcameron
Copy link
Contributor

lizcameron commented Oct 28, 2019

Updated design for Guidance message from UX: https://app.zeplin.io/project/5baa564c05c2eba0d2b89568/dashboard?seid=5c59ad214e1897355941da14
Screenreader UX to follow.

@lizcameron
Copy link
Contributor

@PriyaKR
Copy link
Contributor

PriyaKR commented Nov 6, 2019

Is the guidance just been added to canonical media player page or even on amp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
articles-av-epic Current focus for the articles features stream ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants