Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Nassim fonts for Arabic, Urdu, Pashto #2713

Closed
jamesdonoh opened this issue Jul 24, 2019 · 3 comments · Fixed by #2843
Closed

Use correct Nassim fonts for Arabic, Urdu, Pashto #2713

jamesdonoh opened this issue Jul 24, 2019 · 3 comments · Fixed by #2843
Assignees
Labels
ws-articles Tasks for the WS Articles Team

Comments

@jamesdonoh
Copy link
Contributor

jamesdonoh commented Jul 24, 2019

Testing notes
[Tester to complete with developer when issue is picked up]

Is your feature request related to a problem? Please describe.
Following #2732 we are temporarily going to use NassimPersian for all of APUP.

Once BBC-archive/psammead#735 is done all of the correct Nassim fonts will be available in Psammead, meaning that we can use the correct version of each font for the three remaining Arabic-script services (Arabic, Urdu, Pashto).

respective fonts for each of the services:

  F_NASSIM_ARABIC_REGULAR
  F_NASSIM_ARABIC_BOLD
  F_NASSIM_PASHTO_REGULAR
  F_NASSIM_PASHTO_BOLD
  F_NASSIM_URDU_REGULAR
  F_NASSIM_URDU_BOLD

Describe the solution you'd like

  • Similar to how persian does it add the correct nassim fontfaces to each of the service configs for Arabic, Urdu and Pashto
  • Add screenshots for before and after and get UX to review
  • Check if any changes are required to Storybook in SImorgh

Testing notes

  • Check using DevTools that the correct version of the Nassim font is used on each service's articles
  • Check that no other styling is adversely impacted (e.g. inline link changes)
  • Test how it looks on older/smaller devices
  • Dev and test to decide on best way of providing test coverage for correct font being used

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@jamesdonoh jamesdonoh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-current-epic labels Jul 24, 2019
@jamesdonoh jamesdonoh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jul 24, 2019
@jamesdonoh
Copy link
Contributor Author

Blocked on BBC-archive/psammead#735 which the Shared Components pod will be picking up following clarification from UX.

@jamesdonoh jamesdonoh changed the title Use Nassim fonts for Arabic, Urdu, Pashto Use correct Nassim fonts for Arabic, Urdu, Pashto Jul 25, 2019
@twinlensreflex twinlensreflex removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jul 30, 2019
@jamesdonoh
Copy link
Contributor Author

Unblocked following that BBC-archive/psammead#1516

@jamesdonoh jamesdonoh removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jul 31, 2019
@RayNjeri RayNjeri self-assigned this Jul 31, 2019
@RayNjeri
Copy link

RayNjeri commented Aug 5, 2019

@jamesdonoh jamesdonoh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 6, 2019
@jimjohnsonrollings jimjohnsonrollings removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 6, 2019
@jimjohnsonrollings
Copy link
Contributor

Blocking PRs are both merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants