-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL subheadline block #1801
Comments
Blocked on adding Nassim Persian to Simorgh #1910 |
No longer blocked on #1910; now blocked on BBC-archive/psammead#543 |
The above issue was closed, assuming this is now unblocked so we should try to pick up. |
I suspect that all of this works already - so maybe this needs just to be to check everything is correct. |
Blocked pending #2732 |
Subhead (H2) type sizes: |
Unblocked following BBC-archive/psammead#1516 |
Blocked pending #2713 |
Checked as per the description and per the values specified here by @nataliesmart and everything seems to check off, both on Chrome and Firefox. Further UX review is welcomed. |
Closing this issue as we believe the treatment on live is as expected, please reopen if not. |
There's no subhead on the second, third and fourth links to check. The first link's subhead matches the type specs above. |
Is your feature request related to a problem? Please describe.
We want our subheadline block to work for RTL articles (Persian, Arabic, Urdu, Pashto).
Describe the solution you'd like
As a result of #2713, the NassimPersian font should be loaded for all 4 services and we should already have the text direction being right-to-left. This ticket is to ensure that the implementation matches the designs (except for it not using the correct service-specific font).
If the font sizes and line heights need updating, they should be discussed with UX design before implementing any changes
gel-foundations
For each service we should import the Arabic typography settings from here:
import { arabic } from '@bbc/gel-foundations/scripts'
-
s and punctuation removed.half space
) special character in IDs by replacing it with a hyphen - ensure we have a unit test & storybook example with text that has this zero-width-non-joiner character.Testing notes
Testing URL's
https://www.test.bbc.com/arabic/articles/c69dvq19k63o
https://www.test.bbc.com/persian/articles/c4vlle3q337o
https://www.test.bbc.com/urdu/articles/cx621klkm1ro
https://www.test.bbc.com/pashto/articles/cng0e8v85eko
Dev insight: Update unit snapshot tests.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: