This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update inputProvider to toggle on serviceName not language #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
… input-provider
dr3
suggested changes
Jun 21, 2019
packages/utilities/psammead-storybook-helpers/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Denis Hernandez <46446236+DenisBBC@users.noreply.github.com>
dr3
approved these changes
Jun 24, 2019
|
Hi @sadickisaac, could you take a look at this please. When I checkout input-provider and view the StoryPromo > StoryPromo > Default I get the error |
|
|
|
Can't reproduce the error. This is a breaking change and has not been pulled to any other packages. It should not affect other packages that use |
|
All good, unit tests all pass, this is ready for merge. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #671
Overall change: Update inputProvider to toggle on serviceName not language.
Code changes:
inputProviderto pass object{ script, dir, service, inputs }servicetodirDecoratorinputProvidertests