Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update inputProvider to toggle on serviceName not language #671

Closed
ghost opened this issue Jun 21, 2019 · 0 comments · Fixed by #674
Closed

Update inputProvider to toggle on serviceName not language #671

ghost opened this issue Jun 21, 2019 · 0 comments · Fixed by #674
Labels
ws-home Tasks for the WS Home Team
Milestone
Tech tasks (WS FP)

Comments

@ghost
Copy link

ghost commented Jun 21, 2019 •
edited by dr3
Loading

Is your feature request related to a problem? Please describe.
Now that the font applied to a component will be based on the service #573 , we currently have to include LANGUAGE_VARIANTS to make a select knob in storybook. This means we will have two select input knobs with the same values and the user will have to select twice.

Describe the solution you'd like
Update inputProvider to have a dropdown of services, not languages, and then return the service name out in the provider for the components to use.

Testing notes
[Tester to complete]

Dev insight: Unit Tests will be sufficient

Additional context
Add any other context or screenshots about the feature request here.

Blocking #543
@ghost ghost added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Jun 21, 2019
@ghost ghost added this to the Tech tasks (WS FP) milestone Jun 21, 2019
@dr3 dr3 mentioned this issue Jun 21, 2019
Closed
@dr3 dr3 changed the title Update inputProvider to pass the language Update inputProvider to toggle on serviceName not language Jun 21, 2019
@dr3 dr3 added ws-fp-v1 and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Jun 21, 2019
@ghost ghost self-assigned this Jun 21, 2019
@ghost ghost mentioned this issue Jun 21, 2019
Merged
3 tasks
@ghost ghost closed this as completed in #674 Jun 26, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Tech tasks (WS FP)
Development

Successfully merging a pull request may close this issue.

Update inputProvider to toggle on serviceName not language BBC-archive/psammead
1 participant
@dr3