Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update GEL Typography values #586

Merged
merged 13 commits into from
Jun 12, 2019
Merged

Update GEL Typography values #586

merged 13 commits into from
Jun 12, 2019

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Jun 5, 2019

Resolves #565

Overall change:
Update the Typography values to match with the latest changes in the UX Font Stacks & Styles spreadsheet.

Code changes:

  • Go through all the scripts files and update the values that have changed.
  • Update getTypeSizes test
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@DenisHdz DenisHdz added ws-home Tasks for the WS Home Team ws-fp-v1 labels Jun 5, 2019
@DenisHdz DenisHdz added this to the Localisation & Fonts (WS FP) milestone Jun 5, 2019
@DenisHdz DenisHdz self-assigned this Jun 5, 2019
dr3
dr3 suggested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a breaking change? Dont want to pull it in by mistake,

Other than that LGTM so long as the UX review is very intensive to ensure the values are correct

@DenisHdz DenisHdz mentioned this pull request Jun 5, 2019
Merged
3 tasks
ghost
ghost previously approved these changes Jun 12, 2019
View reviewed changes
@sareh sareh added the ws-articles Tasks for the WS Articles Team label Jun 12, 2019
@WeimingFan
Copy link

This Typography values is approved against UX GEL setting. Fan

1 similar comment
@WeimingFan
Copy link

This Typography values is approved against UX GEL setting. Fan

@jamesbrumpton
Copy link
Contributor

LGTM.

@DenisHdz DenisHdz merged commit d518fb2 into latest Jun 12, 2019
@DenisHdz DenisHdz deleted the update-typography-values branch June 12, 2019 14:16
@dr3 dr3 mentioned this pull request Jun 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@DenisHdz DenisHdz

Labels
ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Localisation & Fonts (WS FP)
Development

Successfully merging this pull request may close these issues.

Update GEL typograhy values
5 participants
@DenisHdz @WeimingFan @jamesbrumpton @dr3 @sareh