Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update GEL typograhy values #565

Closed
DenisHdz opened this issue May 29, 2019 · 0 comments · Fixed by #586
Closed

Update GEL typograhy values #565

DenisHdz opened this issue May 29, 2019 · 0 comments · Fixed by #586
Assignees
Labels
ws-home Tasks for the WS Home Team

Comments

@DenisHdz
Copy link
Contributor

DenisHdz commented May 29, 2019

Is your feature request related to a problem? Please describe.
We have to update the Typography values to match the latest changes in the UX Font Stacks & Styles spreadsheet.

Describe the solution you'd like
Go through all the scripts files and update the values that have changed.

For example:

Update latin-and-cyrillic typography groupA values as follows:

doublePica: {
groupA: {
fontSize: 20 18,
lineHeight: 24 22,
},

brevier: {
groupA: {
fontSize: 14,
lineHeight: 16 18,
},

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@DenisHdz DenisHdz added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team ws-fp-v1 labels May 29, 2019
@DenisHdz DenisHdz added this to the Localisation & Fonts (WS FP) milestone May 29, 2019
@DenisHdz DenisHdz changed the title Update Double Pica and Brevier typograhy values Update GEL typograhy values Jun 4, 2019
@DenisHdz DenisHdz removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jun 4, 2019
@DenisHdz DenisHdz self-assigned this Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant