Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Caption paragraph padding #491

Merged
merged 16 commits into from
May 9, 2019
Merged

Caption paragraph padding #491

merged 16 commits into from
May 9, 2019

Conversation

twinlensreflex
Copy link
Contributor

@twinlensreflex twinlensreflex commented May 2, 2019 •
edited by sareh
Loading

Resolves #482
Overall change: Remove padding-bottom from last child Paragraph elements in Caption.

Code changes:

  • Added Paragraph to example caption in Figure Storybook
  • Changed styling of p to padding-bottom: 0; when last child of Caption
  • Set padding-bottom on figcaption to 0 at all breakpoints
  • updated snapshots

http://localhost:8080/iframe.html?id=figure--containing-image-imageplaceholder-copyright-and-caption
last child paragraph has padding-bottom value of zero

last child paragraph has padding-bottom value of zero

all other child paragraphs have their normal padding

all other child paragraphs have their normal padding

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@twinlensreflex twinlensreflex self-assigned this May 2, 2019
@twinlensreflex twinlensreflex added the ws-articles Tasks for the WS Articles Team label May 2, 2019
@twinlensreflex twinlensreflex marked this pull request as ready for review May 2, 2019 13:40
sareh
sareh suggested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great locally. I've added some package admin suggestions below.

packages/components/psammead-caption/src/index.jsx Show resolved Hide resolved
packages/components/psammead-caption/src/index.jsx Show resolved Hide resolved
@sareh sareh mentioned this pull request May 7, 2019
Merged
4 tasks
sareh
sareh previously approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good locally!

Bopchy
Bopchy previously approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@twinlensreflex twinlensreflex self-assigned this May 9, 2019
@twinlensreflex twinlensreflex dismissed stale reviews from Bopchy and sareh via 32e2754 May 9, 2019 10:10
@jamesbrumpton
Copy link
Contributor

MERGIO

@twinlensreflex twinlensreflex merged commit 77d048f into latest May 9, 2019
@twinlensreflex twinlensreflex deleted the caption-paragraph-padding branch May 9, 2019 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 left review comments

@sareh sareh sareh approved these changes

@Bopchy Bopchy Bopchy approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@chris-hinds chris-hinds Awaiting requested review from chris-hinds

@jamesdonoh jamesdonoh Awaiting requested review from jamesdonoh

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

Assignees

@oluoluoxenfree oluoluoxenfree

@twinlensreflex twinlensreflex

Labels
high priority ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce caption & paragraph padding
6 participants
@twinlensreflex @jamesbrumpton @sareh @dr3 @Bopchy @oluoluoxenfree