You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Is your feature request related to a problem? Please describe.
When a paragraph is used inside a caption, which it is in simorgh now, the collective paddings are too great
Describe the solution you'd like
Find a way of making it so if the paragraph is the last element in a caption, it doesn't have a bottom padding.
We need to be careful though, we can't just use 'last-child' as simorgh uses paragraphs like
<Grid Item>
<Paragraph>
</GridItem>
So it's always the last-child and needs padding. If you have a figcaption, then the last paragraph element shouldn’t have a padding-bottom.
Current styling
Expected styling
Desired Outcome: The caption has 24px padding from the element below the figure.
Testing notes
storybook for paragraphs in figcaption
Dev insight: Storybook and manual linking to simorgh to ensure the intended behaviour is implemented in all cases in an article.
Is your feature request related to a problem? Please describe.
When a paragraph is used inside a caption, which it is in simorgh now, the collective paddings are too great
Describe the solution you'd like
Find a way of making it so if the paragraph is the last element in a caption, it doesn't have a bottom padding.
We need to be careful though, we can't just use 'last-child' as simorgh uses paragraphs like
So it's always the last-child and needs padding.
![Current designs for pading with figcaption and timestamp](https://user-images.githubusercontent.com/19362408/57013888-8d229180-6c05-11e9-9ef3-8e20715f148f.png)
If you have a figcaption, then the last paragraph element shouldn’t have a padding-bottom.
Current styling
![figcaption without bottom padding on paragraph](https://user-images.githubusercontent.com/19362408/57014105-792b5f80-6c06-11e9-898d-74144662509d.png)
Expected styling
![figcaption with paragraph with bottom padding](https://user-images.githubusercontent.com/19362408/57014107-7af52300-6c06-11e9-8404-38987c0b7f09.png)
Desired Outcome: The caption has 24px padding from the element below the figure.
Testing notes
Dev insight: Storybook and manual linking to simorgh to ensure the intended behaviour is implemented in all cases in an article.
The text was updated successfully, but these errors were encountered: