Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Reduce caption & paragraph padding #482

Closed
1 task done
dr3 opened this issue Apr 29, 2019 · 0 comments · Fixed by #491
Closed
1 task done

Reduce caption & paragraph padding #482

dr3 opened this issue Apr 29, 2019 · 0 comments · Fixed by #491
Assignees
Labels
high priority ws-articles Tasks for the WS Articles Team

Comments

@dr3
Copy link
Contributor

dr3 commented Apr 29, 2019

Is your feature request related to a problem? Please describe.
When a paragraph is used inside a caption, which it is in simorgh now, the collective paddings are too great

image

Describe the solution you'd like
Find a way of making it so if the paragraph is the last element in a caption, it doesn't have a bottom padding.

We need to be careful though, we can't just use 'last-child' as simorgh uses paragraphs like

<Grid Item>
	<Paragraph>
</GridItem>

So it's always the last-child and needs padding.
If you have a figcaption, then the last paragraph element shouldn’t have a padding-bottom.
Current designs for pading with figcaption and timestamp

Current styling
figcaption without bottom padding on paragraph

Expected styling
figcaption with paragraph with bottom padding

Desired Outcome: The caption has 24px padding from the element below the figure.

Testing notes

  • storybook for paragraphs in figcaption

Dev insight: Storybook and manual linking to simorgh to ensure the intended behaviour is implemented in all cases in an article.

@dr3 dr3 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team labels Apr 29, 2019
@twinlensreflex twinlensreflex removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label May 1, 2019
@twinlensreflex twinlensreflex self-assigned this May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
high priority ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants