Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

BBC Reith Qalam typography #3805

Merged
merged 17 commits into from
Oct 6, 2020
Merged

BBC Reith Qalam typography #3805

merged 17 commits into from
Oct 6, 2020

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Sep 29, 2020 •
edited
Loading

Resolves #3800

Overall change:
Updating font line weights / sizes for Qalam in line with spec

Code changes:

  • Update arabic script to use font line weights / sizes for Qalam
  • Removal of arabicPashto script - now superceded by arabic
  • Update changelog, package & package-lock files
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@karinathomasbbc karinathomasbbc added the ws-articles Tasks for the WS Articles Team label Sep 29, 2020
@karinathomasbbc karinathomasbbc self-assigned this Sep 29, 2020
@karinathomasbbc karinathomasbbc added this to the BBC Reith Qalam Font milestone Sep 30, 2020
andrewscfc
andrewscfc approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@andrewscfc andrewscfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming the values used are final: #3805 (comment)

@karinathomasbbc karinathomasbbc merged commit 2881fde into latest Oct 6, 2020
@karinathomasbbc karinathomasbbc deleted the bbc-reith-qalam-typography branch October 6, 2020 15:11
@simonsinclair simonsinclair mentioned this pull request Oct 12, 2020
Merged
3 tasks
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 12, 2020
Merged
@simonsinclair simonsinclair restored the bbc-reith-qalam-typography branch November 19, 2020 09:58
@simonsinclair simonsinclair deleted the bbc-reith-qalam-typography branch December 3, 2020 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewscfc andrewscfc andrewscfc approved these changes

@rhenshaw56 rhenshaw56 rhenshaw56 approved these changes

Assignees

@karinathomasbbc karinathomasbbc

Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
BBC Reith Qalam Font
Development

Successfully merging this pull request may close these issues.

Add Reith Qalam font typography
3 participants
@karinathomasbbc @andrewscfc @rhenshaw56