Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Commit

Permalink
Merge pull request #3805 from bbc/bbc-reith-qalam-typography
Browse files Browse the repository at this point in the history
BBC Reith Qalam typography
  • Loading branch information
karinathomasbbc authored Oct 6, 2020
2 parents 7600ae1 + 84a22db commit 2881fde
Show file tree
Hide file tree
Showing 10 changed files with 4,477 additions and 332 deletions.
1 change: 1 addition & 0 deletions packages/utilities/gel-foundations/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 5.0.0 | [PR#3805](https://github.com/bbc/psammead/pull/3805) BBC Reith Qalam v1.100. Removal of `arabicPashto` script in favour of `arabic` |
| 4.3.0 | [PR#3782](https://github.com/bbc/psammead/pull/3782) Reduce Thai font size |
| 4.2.0 | [PR#3616](https://github.com/bbc/psammead/pull/3616) Update Bengali inline link styling |
| 4.1.0 | [PR#3602](https://github.com/bbc/psammead/pull/3602) Update Thai Canon typography values |
Expand Down
25 changes: 12 additions & 13 deletions packages/utilities/gel-foundations/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,18 @@ You can import the script doing `import { arabic } from '@bbc/gel-foundations/sc
In addition to Latin script defaults, Psammead supports typography for a number of other scripts. We have grouped the scripts that share similiar features as follows:

<!-- prettier-ignore -->
| Group Name | Services | Rationale |
| --------------------------- | -------- | --------------------------- |
| latin-and-cyrillic | News, Hausa, Gahuza, Somali, Swahili, Igbo, Pidgin, Afaan Oromo, Yoruba, Azeri, Indonesia, Uzbek, Serbian, Russian, Ukrainian, Kyrgyz, Uzbek | The typography values for Latin and Cyrillic characters are identical |
| latin-with-diacritics | Vietnamese, Mundo, Afrique, Brasil, Turkish | The diacritics make these values differ from Latin |
| arabic | Urdu, Arabic, Persian | Group as they use the Arabic alphabet |
| arabic-pashto | Pashto | Contains a subset of glyphs that mean it differs from Arabic |
| no-ascenders-or-descenders | Korean, Japanese, Zhongwen, Ukchina, Tigrinya, Amharic | Group all alphabets without ascenders or descenders. This could be implemented as chinese, korean, ethiopic | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| devanagari-and-gurmukhi | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| thai | Thai | Bespoke to the Thai characters |
| bengali | Bengali | Bespoke to the Bengal characters |
| burmese | Burmese | Bespoke to the Burmese characters |
| sinhalese | Sinhala | Bespoke to the Sinhalese characters |
| tamil | Tamil | Bespoke to the Tamil characters |
| Group Name | Services | Rationale |
| --------------------------- | -------- | --------------------------- |
| `latin-and-cyrillic` | News, Hausa, Gahuza, Somali, Swahili, Igbo, Pidgin, Afaan Oromo, Yoruba, Azeri, Indonesia, Uzbek, Serbian, Russian, Ukrainian, Kyrgyz, Uzbek | The typography values for Latin and Cyrillic characters are identical |
| `latin-with-diacritics` | Vietnamese, Mundo, Afrique, Brasil, Turkish | The diacritics make these values differ from Latin |
| `arabic` | Arabic, Pashto, Persian, Urdu | Group as they use the Arabic alphabet |
| `no-ascenders-or-descenders` | Korean, Japanese, Zhongwen, Ukchina, Tigrinya, Amharic | Group all alphabets without ascenders or descenders. This could be implemented as `chinese`, `korean`, `ethiopic` | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| `devanagari-and-gurmukhi` | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| `thai` | Thai | Bespoke to the Thai characters |
| `bengali` | Bengali | Bespoke to the Bengal characters |
| `burmese` | Burmese | Bespoke to the Burmese characters |
| `sinhalese` | Sinhala | Bespoke to the Sinhalese characters |
| `tamil` | Tamil | Bespoke to the Tamil characters |

## Contributing

Expand Down
1 change: 0 additions & 1 deletion packages/utilities/gel-foundations/index.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ const typographyExpectedExports = {

const scriptsExpectedExports = {
arabic: 'object',
arabicPashto: 'object',
bengali: 'object',
burmese: 'object',
chinese: 'object',
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/gel-foundations/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utilities/gel-foundations/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/gel-foundations",
"version": "4.3.0",
"version": "5.0.0",
"sideEffects": false,
"description": "A range of string constants for use in CSS, intended to help implement BBC GEL-compliant webpages and components.",
"repository": {
Expand Down
75 changes: 47 additions & 28 deletions packages/utilities/gel-foundations/src/scripts.js
Original file line number Diff line number Diff line change
@@ -1,28 +1,47 @@
export arabic from './scripts/arabic';

export arabicPashto from './scripts/arabic-pashto';

export bengali from './scripts/bengali';

export burmese from './scripts/burmese';

export devanagariAndGurmukhi from './scripts/devanagari-and-gurmukhi';
export hindi from './scripts/devanagari-and-gurmukhi';
export nepali from './scripts/devanagari-and-gurmukhi';

export cyrillic from './scripts/latin-and-cyrillic';
export cyrillicAndLatin from './scripts/latin-and-cyrillic';
export latin from './scripts/latin-and-cyrillic';

export latinDiacritics from './scripts/latin-with-diacritics';

export chinese from './scripts/no-ascenders-or-descenders';
export ethiopic from './scripts/no-ascenders-or-descenders';
export korean from './scripts/no-ascenders-or-descenders';
export noAscendersOrDescenders from './scripts/no-ascenders-or-descenders';

export sinhalese from './scripts/sinhalese';

export tamil from './scripts/tamil';

export thai from './scripts/thai';
/* eslint-disable import/no-duplicates */
import arabic from './scripts/arabic';

import bengali from './scripts/bengali';

import burmese from './scripts/burmese';

import devanagariAndGurmukhi from './scripts/devanagari-and-gurmukhi';
import hindi from './scripts/devanagari-and-gurmukhi';
import nepali from './scripts/devanagari-and-gurmukhi';

import cyrillic from './scripts/latin-and-cyrillic';
import cyrillicAndLatin from './scripts/latin-and-cyrillic';
import latin from './scripts/latin-and-cyrillic';

import latinDiacritics from './scripts/latin-with-diacritics';

import chinese from './scripts/no-ascenders-or-descenders';
import ethiopic from './scripts/no-ascenders-or-descenders';
import korean from './scripts/no-ascenders-or-descenders';
import noAscendersOrDescenders from './scripts/no-ascenders-or-descenders';

import sinhalese from './scripts/sinhalese';

import tamil from './scripts/tamil';

import thai from './scripts/thai';

export {
arabic,
bengali,
burmese,
devanagariAndGurmukhi,
hindi,
nepali,
cyrillic,
cyrillicAndLatin,
latin,
latinDiacritics,
chinese,
ethiopic,
korean,
noAscendersOrDescenders,
sinhalese,
tamil,
thai,
};
214 changes: 0 additions & 214 deletions packages/utilities/gel-foundations/src/scripts/arabic-pashto.js

This file was deleted.

Loading

0 comments on commit 2881fde

Please sign in to comment.