This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Remove bottom margin from the media player #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great work, @chewu. I've left a note below regarding the Psammead workflow.
andrewscfc
reviewed
Sep 8, 2020
joshcoventry
approved these changes
Sep 9, 2020
andrewscfc
approved these changes
Sep 9, 2020
simonsinclair
approved these changes
Sep 9, 2020
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3726
The psammead media player currently has some bottom margin set. This pushes down the video captions when they are rendered as the captions are rendered outside of the media player container.
Remove the bottom margin from the psammead-media-player component.