Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Remove bottom margin from the media player #3726

Closed
1 task
chris-hinds opened this issue Sep 1, 2020 · 0 comments · Fixed by #3733
Closed
1 task

Remove bottom margin from the media player #3726

chris-hinds opened this issue Sep 1, 2020 · 0 comments · Fixed by #3733
Assignees
Labels
cross-team For visibility for both World Service teams (Engage & Media) ws-articles Tasks for the WS Articles Team

Comments

@chris-hinds
Copy link
Contributor

chris-hinds commented Sep 1, 2020

Is your feature request related to a problem? Please describe.
The psammead media player currently has some bottom margin set. This pushes down the video captions when they are rendered as the captions are rendered outside of the media player container.

Describe the solution you'd like
Remove the bottom margin from the psammead-media-player component.

Where custom styling is required add this to the component in simorgh, psammead-media-player is a generic component used across multiple page types and some page types require different styling, this custom styling should live within simorgh and not the media player component.

Bump package with a major version and don't automatically integrate with Simorgh. Do this via the follow-up issue: bbc/simorgh#7692

Describe alternatives you've considered
N/A

Testing notes

  • Ensure snapshots are up to date

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@chris-hinds chris-hinds added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team cross-team For visibility for both World Service teams (Engage & Media) labels Sep 1, 2020
@chris-hinds chris-hinds self-assigned this Sep 1, 2020
@andrewscfc andrewscfc removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 2, 2020
@chewu chewu self-assigned this Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cross-team For visibility for both World Service teams (Engage & Media) ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants