Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adding a 'dark mode' base64 version of BBC_BLOCKS #3610

Merged
merged 4 commits into from
Jul 16, 2020

Conversation

RichardPK
Copy link
Contributor

@RichardPK RichardPK commented Jul 15, 2020

Part 1/3 to resolve #7185

The first of three PRs to add a dark-mode compatible image placeholder to the psammead-media-player.

1. Add dark mode version of BBC_BLOCKS . (this one)
2. Implement dark mode for psammead-image-placeholder. #3611
3. Implement image placeholder in psammead-media-player. #3600

Overall change:

  • Adding a darkMode compatible base64 version of the BBC logo used in psammead-image-placeholder
  • Updating story logic to also exclude new BBC_BLOCKS_DARK_MODE base64 js file

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK self-assigned this Jul 15, 2020
@RichardPK RichardPK added the ws-media The World Service media stream label Jul 15, 2020
@RichardPK RichardPK marked this pull request as ready for review July 15, 2020 16:00
@RichardPK RichardPK merged commit cb8f35a into latest Jul 16, 2020
@RichardPK RichardPK deleted the add-dark-mode-bbc-blocks branch July 16, 2020 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-media The World Service media stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show placeholder while MAP player is loading
3 participants