This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Adding a 'dark mode' base64 version of BBC_BLOCKS #3610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/3 to resolve #7185
The first of three PRs to add a dark-mode compatible image placeholder to the
psammead-media-player
.1. Add dark mode version of BBC_BLOCKS . (this one)
2. Implement dark mode for
psammead-image-placeholder
. #36113. Implement image placeholder in
psammead-media-player
. #3600Overall change:
psammead-image-placeholder
BBC_BLOCKS_DARK_MODE
base64 js file