This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Psammead Timestamp, Paragraph and Heading Dark Mode #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmccombe
commented
Jul 9, 2020
ryanmccombe
changed the base branch from
latest
to
add-themes-to-storybook-helpers
pharingee
reviewed
Jul 9, 2020
| import { shape, string } from 'prop-types'; | ||
| import { C_SHADOW } from '@bbc/psammead-styles/colours'; | ||
| import { shape, string, bool } from 'prop-types'; | ||
| import { C_SHADOW, C_WHITE } from '@bbc/psammead-styles/colours'; |
There was a problem hiding this comment.
From the zeplin mocks this should be C_LUNAR
There was a problem hiding this comment.
General approach looks good to me
ryanmccombe
changed the base branch from
add-themes-to-storybook-helpers
to
latest
rebeccamcginn
approved these changes
Jul 9, 2020
This was referenced Jul 9, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement for bbc/simorgh#7178
Overall change: Add
darkModeprop to Timestamp, Paragraph and HeadingsCode changes: