This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Fix stories that are broken for variants #3279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3183
Overall change: Add
selectedService
towithServicesKnob
storyProps to make it available to stories that use the knob. AddingselectedService
to storyProps makes the service selected from the dropdown available in a story, through props, as it appears in the dropdown & TEXT_VARIANTS.This change will allow work arounds to get
TEXT_VARIANTS
property values for services with variants to be removed.Code changes:
selectedService
towithServicesKnob
storyProps.