Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix stories that are broken for variants #3279

Merged
merged 6 commits into from
Mar 24, 2020

Conversation

Bopchy
Copy link
Contributor

@Bopchy Bopchy commented Mar 20, 2020

Related to #3183

Overall change: Add selectedService to withServicesKnob storyProps to make it available to stories that use the knob. Adding selectedService to storyProps makes the service selected from the dropdown available in a story, through props, as it appears in the dropdown & TEXT_VARIANTS.

This change will allow work arounds to get TEXT_VARIANTS property values for services with variants to be removed.

Code changes:

  • Add selectedService to withServicesKnob storyProps.
  • Update tests.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@Bopchy Bopchy added ws-home Tasks for the WS Home Team radio-schedules labels Mar 20, 2020
@Bopchy Bopchy self-assigned this Mar 20, 2020
@Bopchy Bopchy changed the title 3183 stories broken for variants Fix stories that are broken for variants Mar 20, 2020
@Bopchy Bopchy marked this pull request as ready for review March 20, 2020 19:39
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Ruth,

Note: psammead-most-read has a little hack that fixes it for variants so after this gets merged we can remove this and update the packages were we need to use this new prop.

@PriyaKR
Copy link
Contributor

PriyaKR commented Mar 24, 2020

The issue cant be tested in this PR.Can be tested when this PR is done #3291

@Bopchy Bopchy merged commit ffe2fbd into latest Mar 24, 2020
@Bopchy Bopchy deleted the 3183-stories-broken-for-variants branch March 24, 2020 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
radio-schedules ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants