Merge pull request #3279 from bbc/3183-stories-broken-for-variants

Fix stories that are broken for variants
BBC-archive · Mar 24, 2020 · ffe2fbd · ffe2fbd
2 parents 63960c4 + 5d4b9e2
commit ffe2fbd
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 2 deletions.
diff --git a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md
@@ -3,6 +3,7 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
+| 8.2.6 | [PR#3279](https://github.com/bbc/psammead/pull/3279) Add `selectedService` to withServicesKnob `storyProps` |
 | 8.2.5 | [PR#3135](https://github.com/bbc/psammead/pull/3135) Talos - Bump Dependencies - @bbc/gel-foundations |
 | 8.2.4 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations |
 | 8.2.3 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations |

diff --git a/packages/utilities/psammead-storybook-helpers/README.md b/packages/utilities/psammead-storybook-helpers/README.md
@@ -17,6 +17,7 @@ This package provides a collection of common values that are used in storybook b
 - `service`: The name of the chosen service e.g. `arabic`.
 - `variant`: The variant value of a chosen service, e.g `serbianLat` will have variant `lat`. Non variant service will default to `default`.
 - `articlePath`: A path to an article in the relevant service.
+- `selectedService`: The name of the selected service as it appears in the dropdown of available services.
 
 2. Toggles the layout directionality of the chosen service.
 

diff --git a/packages/utilities/psammead-storybook-helpers/package-lock.json b/packages/utilities/psammead-storybook-helpers/package-lock.json
diff --git a/packages/utilities/psammead-storybook-helpers/package.json b/packages/utilities/psammead-storybook-helpers/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bbc/psammead-storybook-helpers",
-  "version": "8.2.5",
+  "version": "8.2.6",
   "main": "dist/index.js",
   "module": "esm/index.js",
   "sideEffects": false,

diff --git a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
@@ -45,6 +45,7 @@ export default ({
     dir,
     service,
     variant: variant || 'default',
+    selectedService,
   };
 
   return (

diff --git a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx
@@ -69,6 +69,7 @@ it('should pass the correct props to the story function', () => {
     dir: 'ltr',
     locale: 'en',
     variant: 'default',
+    selectedService: 'news',
   };
 
   expect(mockStoryFn).toHaveBeenCalledWith(expected);
@@ -90,6 +91,7 @@ it('should pass the correct chosen service props to the story function', () => {
     dir: 'rtl',
     locale: 'ar',
     variant: 'default',
+    selectedService: 'arabic',
   };
 
   expect(mockStoryFn).toHaveBeenCalledWith(expected);
@@ -111,6 +113,7 @@ it('should pass the correct chosen service props to the story function', () => {
     dir: 'ltr',
     locale: 'zh-cn',
     variant: 'simp',
+    selectedService: 'ukchinaSimp',
   };
 
   expect(mockStoryFn).toHaveBeenCalledWith(expected);