Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Removing isRequired from mediaInfo prop #3205

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Removing isRequired from mediaInfo prop #3205

merged 3 commits into from
Mar 4, 2020

Conversation

rebeccamcginn
Copy link
Contributor

Resolves #NUMBER

Overall change:
Removed isRequired from a prop that is not always required

Code changes:

  • Removed isRequired from the mediaInfo prop for Canonical Media Player
  • Set the default value for mediaInfo as empty object
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@rebeccamcginn rebeccamcginn added the ws-media The World Service media stream label Mar 4, 2020
@rebeccamcginn rebeccamcginn self-assigned this Mar 4, 2020
@ryanmccombe ryanmccombe merged commit 4408201 into latest Mar 4, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Mar 5, 2020
Merged
@sareh sareh deleted the remove_unnecessary_isRequired branch March 26, 2020 15:21
@snyk-bot snyk-bot mentioned this pull request Feb 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

Assignees

@rebeccamcginn rebeccamcginn

Labels
ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebeccamcginn @ryanmccombe @karinathomasbbc