Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Removing isRequired from mediaInfo prop #3205

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Removing isRequired from mediaInfo prop #3205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b74b0b
Removing isRequired from mediaInfo prop
rebeccamcginn Mar 4, 2020
3f3d08f
Updating changelog and version number for psammead-media-player
rebeccamcginn Mar 4, 2020
8964f2b
Merge branch 'latest' into remove_unnecessary_isRequired
rebeccamcginn Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-media-player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
| ------------- | ---------------------------------------------------------------------------------------------------------------------------- |
| 2.7.4 | [PR#3205](https://github.com/bbc/psammead/pull/3205) Removed isRequired from mediaInfo prop as not always required |
| 2.7.3 | [PR#3151](https://github.com/bbc/psammead/pull/3151) Talos - Bump Dependencies - @bbc/psammead-play-button |
| 2.7.2 | [PR#3113](https://github.com/bbc/psammead/pull/3113) Added bottom margin padding for live radio audio player |
| 2.7.1 | [PR#3060](https://github.com/bbc/psammead/pull/3060) Refactored Message component to display message for Expired AV Stream |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-media-player",
"version": "2.7.3",
"version": "2.7.4",
"description": "Provides a media player with optional placeholder",
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
5 changes: 3 additions & 2 deletions packages/components/psammead-media-player/src/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ CanonicalMediaPlayer.propTypes = {
noJsClassName: string,
noJsMessage: string.isRequired,
mediaInfo: shape({
title: string.isRequired,
title: string,
datetime: string,
duration: string,
durationSpoken: string,
type: oneOf(['video', 'audio']),
guidanceMessage: string,
}).isRequired,
}),
};

CanonicalMediaPlayer.defaultProps = {
Expand All @@ -135,6 +135,7 @@ CanonicalMediaPlayer.defaultProps = {
placeholderSrc: null,
placeholderSrcset: null,
noJsClassName: null,
mediaInfo: {},
};

MediaMessage.propTypes = {
Expand Down