This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Story Promo - Fallback spacing for Leading promo #3150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…fallbacks for Leading promo variant
DenisHdz
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Denis Hernandez <46446236+DenisHdz@users.noreply.github.com>
AlistairGempf
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, based on the Chromatic snapshots and the code.
…ws the Image and Text blocks to remain within block flow and therefore respect width & padding
@sareh i am seeing the text above the image on IE11 across all viewports verifies on browserstack. |
LGTM. |
This was referenced Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3149
Overall change: Leading story promo - ensures there's spacing between image and text blocks when viewing in browsers that don't support CSS Grid (screenshots below are in IE11)
Before Link to live storybook example with Persian text

After Link to local storybook example with Persian text
Code changes:
Add padding onto Text and Image blocks on the appropriate side to create a 'gutter' between the text and the image. e.g. on a RTL service like persian above, the Text block has a
padding-left: 0.5rem;
and the Image block has apadding-right: 0.5rem;
Ensure
dir
prop is being passed to Image and Text blocks, so the correct padding can be added.Remove
position: relative
from top-level StoryPromoWrapper - this allows the Image and Text blocks to remain within block flow and therefore respect width & paddingFollowing this change, I checked all three promo types - Top Regular and Leading, with a media video variant, to ensure layout is as expected for each of them. All appear as expected.
