Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Breakpoints restructuring #3127

Merged
merged 9 commits into from
Feb 13, 2020
Merged

Breakpoints restructuring #3127

merged 9 commits into from
Feb 13, 2020

Conversation

RichardPK
Copy link
Contributor

@RichardPK RichardPK commented Feb 13, 2020 •
edited
Loading

Resolves #2948

Overall change: A small reorganisation of the packages/utilities/gel-foundations/src/breakpoints.js component, to better separate the GEL Grid breakpoints and the GEL Typography breakpoints.

Code changes:

  • Moved the block of consts used in the MEDIA_QUERY_TYPOGRAPHY object down below the grid consts
  • Commented sizes of each REM for ease of use.
  • Added reference to gel typography guidelines.
  • I have assigned myself to this PR and the corresponding issues

@RichardPK RichardPK self-assigned this Feb 13, 2020
@RichardPK RichardPK marked this pull request as ready for review February 13, 2020 09:41
ryanmccombe
ryanmccombe approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amywalkerdev amywalkerdev added ws-home Tasks for the WS Home Team ws-media The World Service media stream ws-articles Tasks for the WS Articles Team labels Feb 13, 2020
DenisHdz
DenisHdz approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @amywalker1987's comment, looks good 👍

amywalkerdev
amywalkerdev approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@sareh sareh merged commit 6fa627e into latest Feb 13, 2020
@sareh sareh deleted the breakpoints-restructuring branch February 13, 2020 16:37
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Feb 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@amywalkerdev amywalkerdev amywalkerdev approved these changes

@DenisHdz DenisHdz DenisHdz approved these changes

Assignees

@RichardPK RichardPK

Labels
ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GEL Breakpoints' MEDIA_QUERY_TYPOGRAPHY object not reflective of device sizes
5 participants
@RichardPK @ryanmccombe @amywalkerdev @DenisHdz @sareh