Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

GEL Breakpoints' MEDIA_QUERY_TYPOGRAPHY object not reflective of device sizes #2948

Closed
1 task
RichardPK opened this issue Jan 16, 2020 · 1 comment · Fixed by #3127
Closed
1 task

GEL Breakpoints' MEDIA_QUERY_TYPOGRAPHY object not reflective of device sizes #2948

RichardPK opened this issue Jan 16, 2020 · 1 comment · Fixed by #3127
Assignees
Labels
discussion Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@RichardPK
Copy link
Contributor

RichardPK commented Jan 16, 2020

Is your feature request related to a problem? Please describe.
The current LAPTOP_AND_LARGER MEDIA_QUERY_TYPOGRAPHY breakpoint within packages/utilities/gel-foundations/src/breakpoints.js has the min-width GEL_GROUP_CD_MIN_WIDTH, which is 600px. The UX team use a 600px break point to describe a tablet or a very small notebook, not a laptop. There is no MEDIA_QUERY_TYPOGRAPHY breakpoint for 1008px, which is the 'laptop and larger' measurement used by designers.

Describe the solution you'd like

  • Rename the LAPTOP_AND_LARGER MEDIA_QUERY_TYPOGRAPHY object key to LARGE_SMARTPHONE... or TABLET... ..._AND_LARGER
  • Add another key-value pair to the MEDIA_QUERY_TYPOGRAPHY for LAPTOP_AND_LARGER using a 1008px const.
  • Add a final key-value pair for a 1280px breakpoint, which is the largest size the designers tend to work towards.

Testing notes
[Tester to complete]

Dev insight:

  • The current LAPTOP_AND_LARGER 600px breakpoint is being used in 19 places, so this update will need to be matched with changes across the rest of the component library to reflect the new break point values.

  • This feature is expected to need manual testing.

Additional context
Example of design breakpoints

image-breakpoints-examples

@RichardPK RichardPK added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. discussion labels Jan 16, 2020
@RichardPK RichardPK self-assigned this Jan 16, 2020
@RichardPK
Copy link
Contributor Author

RichardPK commented Feb 13, 2020

After some digging and conversations with design - there is a distinction between typography break points and grid break points. Rather than changing the way these breakpoints are named (which would have a cascading impact across psammead and simorgh), I have reorged the breakpoints component to make it clearer which consts are for typography, and which are for layouts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant