This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
GEL Breakpoints' MEDIA_QUERY_TYPOGRAPHY object not reflective of device sizes #2948
Labels
discussion
Refinement Needed
This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Is your feature request related to a problem? Please describe.
The current
LAPTOP_AND_LARGER
MEDIA_QUERY_TYPOGRAPHY
breakpoint withinpackages/utilities/gel-foundations/src/breakpoints.js
has the min-widthGEL_GROUP_CD_MIN_WIDTH
, which is 600px. The UX team use a 600px break point to describe a tablet or a very small notebook, not a laptop. There is noMEDIA_QUERY_TYPOGRAPHY
breakpoint for 1008px, which is the 'laptop and larger' measurement used by designers.Describe the solution you'd like
LAPTOP_AND_LARGER
MEDIA_QUERY_TYPOGRAPHY
object key toLARGE_SMARTPHONE...
orTABLET...
..._AND_LARGER
MEDIA_QUERY_TYPOGRAPHY
forLAPTOP_AND_LARGER
using a 1008px const.Testing notes
[Tester to complete]
Dev insight:
The current
LAPTOP_AND_LARGER
600px breakpoint is being used in 19 places, so this update will need to be matched with changes across the rest of the component library to reflect the new break point values.This feature is expected to need manual testing.
Additional context
Example of design breakpoints
The text was updated successfully, but these errors were encountered: