-
Notifications
You must be signed in to change notification settings - Fork 54
Adding padding between audio player and footer #3113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs version and changelog update :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Beautiful use of the GEL consts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed the design referenced in the issue is for OD radio, while the example of the problem is a live radio site. No doubt a change is still necessary, just thought it was worth flagging that the values could be different. The live radio design spacing looks slightly different to OD radio:
The values were approved by Ed |
|
Resolves #3111
Overall change:
Added 32px margin for 1008 and above, 16px margin for 1007 and below
Code changes:
Added media query for margin padding