Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adding padding between audio player and footer #3113

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

rebeccamcginn
Copy link
Contributor

Resolves #3111

Overall change:
Added 32px margin for 1008 and above, 16px margin for 1007 and below

Code changes:
Added media query for margin padding


  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@rebeccamcginn rebeccamcginn added the ws-media The World Service media stream label Feb 11, 2020
@rebeccamcginn rebeccamcginn self-assigned this Feb 11, 2020
Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs version and changelog update :)

Copy link
Contributor

@RichardPK RichardPK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Beautiful use of the GEL consts.

Copy link
Contributor

@RichardPK RichardPK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the design referenced in the issue is for OD radio, while the example of the problem is a live radio site. No doubt a change is still necessary, just thought it was worth flagging that the values could be different. The live radio design spacing looks slightly different to OD radio:

Screenshot 2020-02-11 at 17 00 15

Screenshot 2020-02-11 at 17 08 09

@rebeccamcginn
Copy link
Contributor Author

Just noticed the design referenced in the issue is for OD radio, while the example of the problem is a live radio site. No doubt a change is still necessary, just thought it was worth flagging that the values could be different. The live radio design spacing looks slightly different to OD radio:

Screenshot 2020-02-11 at 17 00 15 Screenshot 2020-02-11 at 17 08 09

The values were approved by Ed

@rebeccamcginn
Copy link
Contributor Author

Just noticed the design referenced in the issue is for OD radio, while the example of the problem is a live radio site. No doubt a change is still necessary, just thought it was worth flagging that the values could be different. The live radio design spacing looks slightly different to OD radio:

Screenshot 2020-02-11 at 17 00 15 Screenshot 2020-02-11 at 17 08 09

@rebeccamcginn rebeccamcginn merged commit 39c660c into latest Feb 11, 2020
@sareh sareh deleted the Live_Radio_Footer_Spacing branch February 21, 2020 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-media The World Service media stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No padding between the live radio audio player and the footer
4 participants