Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

No padding between the live radio audio player and the footer #3111

Closed
1 task
rebeccamcginn opened this issue Feb 11, 2020 · 0 comments · Fixed by #3113
Closed
1 task

No padding between the live radio audio player and the footer #3111

rebeccamcginn opened this issue Feb 11, 2020 · 0 comments · Fixed by #3113
Assignees
@rebeccamcginn
Labels
bug Something isn't working ws-media The World Service media stream

Comments

@rebeccamcginn
Copy link
Contributor

rebeccamcginn commented Feb 11, 2020 •
edited
Loading

Describe the bug
There is currently no padding between the audio player and the footer.

To Reproduce

See https://www.bbc.com/tamil/bbc_tamil_radio/liveradio for an example

Expected behaviour
1008 -> 32px
1007 and below -> 16px

Designs: https://app.zeplin.io/project/5d4d77b1fcbfc79bf47e0294/screen/5df76934d852e81aee9c21ea

Screenshots
If applicable, add screenshots to help explain your problem.

Testing notes

  • This bug fix is expected to need manual testing.
@rebeccamcginn rebeccamcginn added the bug Something isn't working label Feb 11, 2020
@rebeccamcginn rebeccamcginn self-assigned this Feb 11, 2020
@rebeccamcginn rebeccamcginn added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-media The World Service media stream labels Feb 11, 2020
@rebeccamcginn rebeccamcginn mentioned this issue Feb 11, 2020
Closed
@rebeccamcginn rebeccamcginn removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Feb 11, 2020
@rebeccamcginn rebeccamcginn mentioned this issue Feb 11, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebeccamcginn rebeccamcginn

Labels
bug Something isn't working ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding padding between audio player and footer BBC-archive/psammead
1 participant
@rebeccamcginn