Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update Story Promo List border-bottom #3014

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Update Story Promo List border-bottom #3014

merged 3 commits into from
Jan 27, 2020

Conversation

sareh
Copy link
Contributor

@sareh sareh commented Jan 27, 2020 •
edited
Loading

Part of bbc/simorgh#4562

Overall change: Update Story Promo List to only apply border-bottom for below 1008px (groups 0-3)

Code changes:

  • Update styling to only apply border-bottom for less than 1008px (groups 0-3)
  • Major version increase since we do not want to automatically pull in the changes in our application. We should only pull in the changes as part of introducing the Desktop Layout in the application.

Screenshot of Storybook story (http://localhost:8180/?path=/story/components-storypromo-storypromolist--default) shows that above 1008px, there is no border bottom on the List Item.

Screenshot 2020-01-27 at 11 14 43

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@sareh sareh added the ws-home Tasks for the WS Home Team label Jan 27, 2020
@sareh sareh self-assigned this Jan 27, 2020
@sareh sareh mentioned this pull request Jan 27, 2020
Merged
6 tasks
DenisHdz
DenisHdz approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

OlgaLyubin
OlgaLyubin approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@amywalkerdev amywalkerdev merged commit d0c2d92 into latest Jan 27, 2020
@amywalkerdev amywalkerdev deleted the story-promo-border-update branch January 27, 2020 12:25
@sareh sareh mentioned this pull request Jan 29, 2020
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OlgaLyubin OlgaLyubin OlgaLyubin approved these changes

@DenisHdz DenisHdz DenisHdz approved these changes

Assignees

@sareh sareh

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sareh @OlgaLyubin @DenisHdz @amywalkerdev