This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update line heights for latin with diacritics #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
jroebu14
as code owners
thekp
approved these changes
Oct 23, 2019
jroebu14
approved these changes
Oct 24, 2019
This was referenced Oct 24, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2468
Overall change: Update line heights for latin with diacritics, to match new UX requirements.
Code changes:
After this is merged in, the Psammead components and Simorgh should all be updated to use
@bbc/gel-foundationswith the new typography settings.