Merge pull request #2462 from bbc/latin-diacritics-update

Update line heights for latin with diacritics
BBC-archive · Oct 24, 2019 · 2bb1e3e · 2bb1e3e
2 parents 42e5e3e + f7c3e5b
commit 2bb1e3e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 15 deletions.
diff --git a/packages/utilities/gel-foundations/CHANGELOG.md b/packages/utilities/gel-foundations/CHANGELOG.md
@@ -3,6 +3,7 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
+| 3.4.1 | [PR#2462](https://github.com/bbc/psammead/pull/2462) Update line heights for Latin with Diacritics. |
 | 3.4.0 | [PR#2169](https://github.com/bbc/psammead/pull/2169) Add generic script exports - cyrillicAndLatin, devanagariAndGurmukhi & noAscendersOrDescenders |
 | 3.3.3 | [PR#1847](https://github.com/bbc/psammead/pull/1847) Fixed Telugu typos |
 | 3.3.2 | [PR#1806](https://github.com/bbc/psammead/pull/1806/) Change strings to booleans |

diff --git a/packages/utilities/gel-foundations/package-lock.json b/packages/utilities/gel-foundations/package-lock.json
diff --git a/packages/utilities/gel-foundations/package.json b/packages/utilities/gel-foundations/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bbc/gel-foundations",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "sideEffects": false,
   "description": "A range of string constants for use in CSS, intended to help implement BBC GEL-compliant webpages and components.",
   "repository": {

diff --git a/packages/utilities/gel-foundations/src/scripts/latin-with-diacritics.js b/packages/utilities/gel-foundations/src/scripts/latin-with-diacritics.js
@@ -76,57 +76,57 @@ const latinWithDiacriticsTypography = {
   canon: {
     groupA: {
       fontSize: '28',
-      lineHeight: '32',
+      lineHeight: '36',
     },
     groupB: {
       fontSize: '32',
-      lineHeight: '38',
+      lineHeight: '42',
     },
     groupD: {
       fontSize: '44',
-      lineHeight: '52',
+      lineHeight: '58',
     },
   },
   trafalgar: {
     groupA: {
-      fontSize: '20',
-      lineHeight: '24',
+      fontSize: '22',
+      lineHeight: '28',
     },
     groupB: {
       fontSize: '24',
-      lineHeight: '30',
+      lineHeight: '32',
     },
     groupD: {
       fontSize: '32',
-      lineHeight: '38',
+      lineHeight: '42',
     },
   },
   paragon: {
     groupA: {
       fontSize: '20',
-      lineHeight: '24',
+      lineHeight: '26',
     },
     groupB: {
       fontSize: '22',
-      lineHeight: '28',
+      lineHeight: '30',
     },
     groupD: {
       fontSize: '28',
-      lineHeight: '34',
+      lineHeight: '38',
     },
   },
   doublePica: {
     groupA: {
       fontSize: '18',
-      lineHeight: '22',
+      lineHeight: '24',
     },
     groupB: {
       fontSize: '20',
-      lineHeight: '24',
+      lineHeight: '26',
     },
     groupD: {
       fontSize: '24',
-      lineHeight: '30',
+      lineHeight: '32',
     },
   },
   greatPrimer: {