This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Bump psammead-media-player #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
ghost
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
|
https://github.com/bbc/psammead/pull/1919/files#diff-f9a34775b213d576f538360e3242a9daR6 Should we update the text in the changelog here, to like "version bump", since it is misleading? I don't think you will need to update the package's version again since it's just a changelog. |
thekp
approved these changes
Aug 27, 2019
dr3
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: Bump
versionmissed on #1919Code changes: