This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Telugu typos #1847
Merged
Telugu typos #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharingee
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
thekp
approved these changes
Aug 22, 2019
hotinglok
approved these changes
Aug 22, 2019
FK78
approved these changes
Aug 22, 2019
thekp
suggested changes
Aug 22, 2019
|
sorry i wasn't clear earlier, i meant these files: https://github.com/bbc/psammead/blob/latest/packages/utilities/gel-foundations/CHANGELOG.md |
Updates changelogs for gel-foundations, psammead-assets, psammead-styles
thekp
approved these changes
Aug 22, 2019
FK78
approved these changes
Aug 22, 2019
jamesbhobbs
reviewed
Aug 23, 2019
| @@ -376,7 +376,7 @@ export const sinhala = sinhalaStyles; | |||
| export const somali = helmetFontStyles; | |||
| export const swahili = helmetFontStyles; | |||
| export const tamil = tamilStyles; | |||
| export const telugu = teleguStyles; | |||
| export const telugu = teluguStyles; | |||
There was a problem hiding this comment.
Technically isn't this actually a breaking change, therefore needing a major version change?
There was a problem hiding this comment.
oh wait no it isn't because the export is ACTUALLY spelt correctly!
There was a problem hiding this comment.
Technically, no. Because the export name did not change. That was always correct
There was a problem hiding this comment.
ahhhhhh 🙈 on that note, time for the weekend 🏃
jamesbhobbs
suggested changes
Aug 23, 2019
jamesbhobbs
approved these changes
Aug 23, 2019
dr3
approved these changes
Aug 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1776
Overall change:
Fix Telugu typos in two packages
Code changes: