Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Telugu typos #1847

Merged
merged 11 commits into from
Aug 23, 2019
Merged

Telugu typos #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
608f4f0
Fix Telugu typos in @bbc/gel-foundations README
Aug 22, 2019
3cb16f3
Bump package version for gel-foundations
Aug 22, 2019
9c03eb3
Fix Telugu typos in psammead-styles font-families
Aug 22, 2019
08fac64
Bump package version for psammead-styles
Aug 22, 2019
accf3b4
Fix Telugu typo in psammead-assets CHANGELOG
Aug 22, 2019
c1414b7
Bump package version for psammead-assets
Aug 22, 2019
b3daf5a
Update changelogs
Aug 22, 2019
6c6f50b
Merge branch 'latest' into telugu-typos
thekp Aug 22, 2019
d1d2612
Merge branch 'latest' into telugu-typos
FK78 Aug 22, 2019
bcf6654
Merge branch 'latest' into telugu-typos
staylos92 Aug 23, 2019
e9ac609
Merge branch 'latest' into telugu-typos
staylos92 Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/utilities/gel-foundations/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 3.3.3 | [PR#1847](https://github.com/bbc/psammead/pull/1847) Fixed Telugu typos |
| 3.3.2 | [PR#1806](https://github.com/bbc/psammead/pull/1806/) Change strings to booleans |
| 3.3.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation |
| 3.3.0 | [PR#1794](https://github.com/bbc/psammead/pull/1794) Add david dependency badges |
Expand Down
4 changes: 2 additions & 2 deletions packages/utilities/gel-foundations/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ In addition to Latin script defaults, Psammead supports typography for a number
| latin-with-diacritics | Vietnamese, Mundo, Afrique, Brasil, Turkish | The diacritics make these values differ from Latin |
| arabic | Urdu, Arabic, Persian | Group as they use the Arabic alphabet |
| arabic-pashto | Pashto | Contains a subset of glyphs that mean it differs from Arabic |
| no-ascenders-or-descenders | Korean, Japanese, Zhongwen, Ukchina, Tigrinya, Amharic | Group all alphabets without ascenders or descenders. This could be implemented as chinese, korean, ethiopic | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telegu | The typography values for Devanagari and Gurmukhi characters are identical |
| devanagari-and-gurmukhi | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telegu | The typography values for Devanagari and Gurmukhi characters are identical |
| no-ascenders-or-descenders | Korean, Japanese, Zhongwen, Ukchina, Tigrinya, Amharic | Group all alphabets without ascenders or descenders. This could be implemented as chinese, korean, ethiopic | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| devanagari-and-gurmukhi | Hindi, Nepali, Gujarati, Punjabi, Marathi, Telugu | The typography values for Devanagari and Gurmukhi characters are identical |
| thai | Thai | Bespoke to the Thai characters |
| bengali | Bengali | Bespoke to the Bengal characters |
| burmese | Burmese | Bespoke to the Burmese characters |
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/gel-foundations/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utilities/gel-foundations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/gel-foundations",
"version": "3.3.2",
"version": "3.3.3",
"sideEffects": false,
"description": "A range of string constants for use in CSS, intended to help implement BBC GEL-compliant webpages and components.",
"repository": {
Expand Down
3 changes: 2 additions & 1 deletion packages/utilities/psammead-assets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 2.2.3 | [PR#1847](https://github.com/bbc/psammead/pull/1847) Fixed Telugu typos |
| 2.2.2 | [PR#1806](https://github.com/bbc/psammead/pull/1806/) Change strings to booleans |
| 2.2.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation |
| 2.2.0 | [PR#1794](https://github.com/bbc/psammead/pull/1794) Add david dependency badges |
| 2.1.0 | [PR#1759](https://github.com/bbc/psammead/pull/1759) Add Uzbek SVG & update names for Telugu & Ukrainian. |
| 2.0.1 | [PR#1682](https://github.com/bbc/psammead/pull/1682) Move all dev dependencies to top level package.json |
| 2.0.0 | [PR#1646](https://github.com/bbc/psammead/pull/1646) Add SVGs for these services japanese, mundo, punjabi. Update SVG name from turkish to turkce. Update outline styles of SVG to be white. |
| 1.2.0 | [PR#1523](https://github.com/bbc/psammead/pull/1523) Add SVGs for these services: afaanoromoo, afrique, amharic, arabic, azeri, bengali, burmese, gahuza, gujarati, hausa, hindi, igbo, indonesia, korean, kyrgyz, marathi, nepali, news, pashto, persian, pidgin, russian, serbian, sinhala, somali, swahili, tamil, telegu, thai, tigrinya, turkish, urdu, ukchina, ukranian, vietnamese, zhongwen. Update these existing SVGs: igbo, news, persian, pidgin, thai, yoruba. |
| 1.2.0 | [PR#1523](https://github.com/bbc/psammead/pull/1523) Add SVGs for these services: afaanoromoo, afrique, amharic, arabic, azeri, bengali, burmese, gahuza, gujarati, hausa, hindi, igbo, indonesia, korean, kyrgyz, marathi, nepali, news, pashto, persian, pidgin, russian, serbian, sinhala, somali, swahili, tamil, telugu, thai, tigrinya, turkish, urdu, ukchina, ukranian, vietnamese, zhongwen. Update these existing SVGs: igbo, news, persian, pidgin, thai, yoruba. |
| 1.1.1 | [PR#1360](https://github.com/bbc/psammead/pull/1360) Bump because NPM didnt publish properly for some reason |
| 1.1.0 | [PR#1214](https://github.com/bbc/psammead/pull/1214) Export ESM modules via existing API |
| 1.0.6 | [PR#1179](https://github.com/bbc/psammead/pull/1179) use `psammead-test-helpers@1.0.2`|
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/psammead-assets/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utilities/psammead-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-assets",
"version": "2.2.2",
"version": "2.2.3",
"sideEffects": false,
"description": "A collection of common assets that are likely to be required by many Psammead components or users, such as SVGs or small scripts.",
"repository": {
Expand Down
1 change: 1 addition & 0 deletions packages/utilities/psammead-styles/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 2.1.2 | [PR#1847](https://github.com/bbc/psammead/pull/1847) Fixed Telugu typos |
| 2.1.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation |
| 2.1.0 | [PR#1794](https://github.com/bbc/psammead/pull/1794) Add david dependency badges |
| 2.0.4 | [PR#1777](https://github.com/bbc/psammead/pull/1777) Make psammead-styles treeshakable. |
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/psammead-styles/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utilities/psammead-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-styles",
"version": "2.1.1",
"version": "2.1.2",
"description": "A collection of string constants for use in CSS, containing non-GEL styling details that are bespoke to specific BBC services and products.",
"repository": {
"type": "git",
Expand Down
10 changes: 5 additions & 5 deletions packages/utilities/psammead-styles/src/font-families.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,13 @@ const tamilStyles = {
};

/*
* TELEGU
* TELUGU
*/
const teleguFontFamily = `font-family: Mallanna, "Noto Sans Telugu", "Hind Guntur", Gautami, "Kohinoor Telugu", sans-serif;`;
const teluguFontFamily = `font-family: Mallanna, "Noto Sans Telugu", "Hind Guntur", Gautami, "Kohinoor Telugu", sans-serif;`;

const teleguStyles = {
const teluguStyles = {
sansRegular: `
${teleguFontFamily}
${teluguFontFamily}
${getFontStyleAndWeight('normal', 400)}
`,
};
Expand Down Expand Up @@ -376,7 +376,7 @@ export const sinhala = sinhalaStyles;
export const somali = helmetFontStyles;
export const swahili = helmetFontStyles;
export const tamil = tamilStyles;
export const telugu = teleguStyles;
export const telugu = teluguStyles;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically isn't this actually a breaking change, therefore needing a major version change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait no it isn't because the export is ACTUALLY spelt correctly!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, no. Because the export name did not change. That was always correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhhh 🙈 on that note, time for the weekend 🏃

export const thai = thaiStyles;
export const tigrinya = tigrinyaStyles;
export const turkce = helmetFontStyles;
Expand Down