Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

update import of scripts #1479

Merged
merged 3 commits into from
Jul 24, 2019
Merged

update import of scripts #1479

merged 3 commits into from
Jul 24, 2019

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Jul 24, 2019 •
edited
Loading

Resolves n/a

Overall change: We need to import all scripts

Code changes:

  • add import * as script
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@thekp thekp self-assigned this Jul 24, 2019
@thekp thekp requested review from andrew-nowak and dr3 and removed request for andrew-nowak July 24, 2019 14:47
@thekp thekp marked this pull request as ready for review July 24, 2019 14:48
@thekp
Copy link
Contributor Author

thekp commented Jul 24, 2019 •
edited
Loading

Not production, this PR does not require testing.

@thekp thekp merged commit dce2883 into latest Jul 24, 2019
@thekp thekp deleted the update-script-import branch July 24, 2019 15:11
@thekp thekp mentioned this pull request Jul 25, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrew-nowak andrew-nowak andrew-nowak approved these changes

@dr3 dr3 dr3 approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@thekp thekp

Labels
simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thekp @andrew-nowak @dr3