Macro-support workaround breaks IntelliJ plugin

[gkossakowski]

Apparently, the pattern bazel-deps uses to get around ijar+scala macros issue confuses the IntelliJ plugin. The problem is with using "//jar:file".

See the corresponding issue in the intellij plugin: bazelbuild/intellij#142
I'm cross-posting between repos because it's not clear whether this issue should be fixed by bazel-deps, the intellij plugin or maybe even bazel core.

The discussion which points at bazel-deps as a source of problem is here: bazelbuild/intellij#97 (comment)

[johnynek]

we have to do it this way until the scala rules can support macros in jars. maven_jar will not work.

The solution is in the scala rules to make a scala_jar repository rule which can not use ijar on the output, but give a sane java_provider.

[ittaiz]

I'll try and expedite the scala_import rule as fast as I can and once it's in baze_deps will be able o use it

…

On Wed, 11 Oct 2017 at 21:49 P. Oscar Boykin ***@***.***> wrote: we have to do it this way until the scala rules can support macros in jars. maven_jar will not work. The solution is in the scala rules to make a scala_jar repository rule which can not use ijar on the output, but give a sane java_provider. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#81 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF6tWh_j8qlr60eUQmyABSKrtnRVFks5srQ2tgaJpZM4P15a7> .

[gkossakowski]

Ittai, Do you have a sense of how much work is left?
Our homegrown aspects that generate intellij project files are subtly broken by recent bazel/rules_scala upgrade and i'm trying to estimate whether i should dive into fixing them

[gkossakowski]

I found a workaround for our internal issues so I'm not on fire anymore but still very interested in getting the official intellij plugin to work.

[ittaiz]

Excellent. I'll update as soon as I have progress

…

On Thu, 12 Oct 2017 at 0:57 Grzegorz Kossakowski ***@***.***> wrote: I found a workaround for our internal issues so I'm not on fire anymore but still very interested in getting the official intellij plugin to work. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#81 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF_n1oIp6bHKRvML1gOOA1WWsgC3Nks5srTmwgaJpZM4P15a7> .

[kevingessner]

I believe #101 has fixed this -- scala deps work in intellij for me these days.

[johnynek]

reopen if there is an issue.