Add ability to use PathToUnderscores in proto to Swift gen
#919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be surprised if this is the best way to get this information piped all the way to here but the aspect implementation makes it a bit odd, from my perspective. Please let me know if there's a better way and then I can update the comments/docs and add a test(s). |
mattrobmattrob
force-pushed
the
mr/protoc.arg.PathToUnderscore.option
branch
2 times, most recently
from
f0957a3 to
a227d61
Compare
mattrobmattrob
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins and
thii
as code owners
|
I'm supportive of being flexible here. Can you add a test so we make sure it doesn't regress? (I don't know how hard that will be since I think this is under tested now) |
mattrobmattrob
changed the title
PathToUnderscores in proto to Swift genPathToUnderscores in proto to Swift gen
keith
reviewed
Oct 13, 2022
mattrobmattrob
requested review from
keith
and removed request for
brentleyjones,
segiddins,
BalestraPatrick and
thii
Add the ability to provide `--features swift.generate_path_to_underscores_from_proto_files` to change the `FileNaming` param passed to protoc from `FullPath` to `PathToUnderscores`. Fixes bazelbuild#552.
mattrobmattrob
force-pushed
the
mr/protoc.arg.PathToUnderscore.option
branch
from
861a532 to
cb8f9b8
Compare
keith
approved these changes
Oct 26, 2022
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
…ild#919) Add the ability to provide `--features swift.generate_path_to_underscores_from_proto_files` to change the `FileNaming` param passed to protoc from `FullPath` to `PathToUnderscores`. Fixes bazelbuild#552.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to provide
--features swift.generate_path_to_underscores_from_proto_filesto change theFileNamingparam passed to protoc fromFullPathtoPathToUnderscores.Fixes #552.