common: remove file_system library
#797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
file_system
branch
7 times, most recently
from
1b4476c to
2bfb948
Compare
keith
reviewed
Apr 13, 2022
Remove the custom `file_system` library in favour of `std::filesystem`. This allows us to avoid having to re-implement the functionality on all the platforms. This will also enable us to support Windows eventually without having to do all the file system handling (which requires a significant amount of UTF-8 to UCS-2 conversions) and trying to emulate the semantics of the functions.
keith
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the custom
file_systemlibrary in favour ofstd::filesystem.This allows us to avoid having to re-implement the functionality on all
the platforms. This will also enable us to support Windows eventually
without having to do all the file system handling (which requires a
significant amount of UTF-8 to UCS-2 conversions) and trying to emulate
the semantics of the functions.