Persist pch files in output dir #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a feature to persist pch files created internally. This simply adds the flag pch_output_dir to point at a directory when the feature is present
congt
approved these changes
Oct 19, 2021
|
what's the used for? can you add a test? |
|
Swift compiles a pch in some cases and you can enable this flag to persist them amongst different invocations. For a test you mean asserting the flag is passed w/ the configurator - something like |
|
yea something like that is good |
|
Nice, added a quick check for that 👍 |
|
@keith thanks for the quick turnaround 🙇♂️ |
|
Thanks for the PR! |
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a feature to persist pch files created internally. This simply
adds the flag pch_output_dir to point at a directory when the feature is
present