Fixes for using -embed-bitcode on Xcode13 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add some tests for this if possible? |
rsahara
force-pushed
the
fix/output-file-map-with-embed-bitcode
branch
from
6498dff
to
b9fe5fc
Compare
|
I tried to mimic the other tests. Please let me know if this is not the right way. |
brentleyjones
approved these changes
Sep 14, 2021
thii
approved these changes
Sep 16, 2021
added 3 commits
September 17, 2021 10:20
Tests that the bitcode objects will be in the output file map ('llvm-bc')
when bitcode must be embedded. Prevents bazelbuild#682.
thii
force-pushed
the
fix/output-file-map-with-embed-bitcode
branch
from
711f876
to
ad67efd
Compare
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Adds the file path of `llvm-bc` files to the output file maps created by rules_swift, when `-embed-bitcode` is requested. Without this file path, on Xcode13, we get compile errors due to object files not created in the correct paths - the paths specified as `object` in the output file maps are ignored. Fixes bazelbuild#682.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the file path of
llvm-bcfiles to the output file maps created by rules_swift, when-embed-bitcodeis requested.Without this file path, on Xcode13, we get compile errors due to object files not created in the correct paths - the paths specified as
objectin the output file maps are ignored.Fixes #682.