-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for swiftsourceinfo #523
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
d4e62ec
to
cd7294a
Compare
421bc67
to
f643023
Compare
f643023
to
2caf9a9
Compare
2caf9a9
to
e2c4ca3
Compare
a69ff26
to
a00304d
Compare
do we know what Xcode uses this for yet? |
No, I'm not sure what Xcode uses this for at the moment. This is all the info I've found, I'm sure you've seen: https://forums.swift.org/t/proposal-emitting-source-information-file-during-compilation/28794 but I'm sure Xcode got/gets this information in other ways. |
yea it would just be nice to see what this fixes / breaks so we know it's producing valid ones |
I will look into it a bit and see what I can find out. |
From a @kastiglione thread I found: "it's for swiftc to emit diagnostics across module boundaries" and "so as I understand, it's useful to the IDE only indirectly (the IDE displaying the compiler's diagnostics)" |
Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule. PiperOrigin-RevId: 398579438 (cherry picked from commit 4e45e79) # Conflicts: # swift/internal/compiling.bzl Fixes #496 Closes #523 Co-authored-by: Googler <noreply@google.com>
…elbuild#692) Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule. PiperOrigin-RevId: 398579438 (cherry picked from commit 4e45e79) # Conflicts: # swift/internal/compiling.bzl Fixes bazelbuild#496 Closes bazelbuild#523 Co-authored-by: Googler <noreply@google.com>
I took a stab at #496