Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for swiftsourceinfo #523

Closed
wants to merge 5 commits into from

Conversation

codeman9
Copy link
Contributor

@codeman9 codeman9 commented Nov 12, 2020

I took a stab at #496

@google-cla
Copy link

google-cla bot commented Nov 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 12, 2020
@codeman9
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 12, 2020
@google-cla
Copy link

google-cla bot commented Nov 24, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@keith
Copy link
Member

keith commented Aug 31, 2021

do we know what Xcode uses this for yet?

@codeman9
Copy link
Contributor Author

do we know what Xcode uses this for yet?

No, I'm not sure what Xcode uses this for at the moment.

This is all the info I've found, I'm sure you've seen: https://forums.swift.org/t/proposal-emitting-source-information-file-during-compilation/28794 but I'm sure Xcode got/gets this information in other ways.

@keith
Copy link
Member

keith commented Aug 31, 2021

yea it would just be nice to see what this fixes / breaks so we know it's producing valid ones

@codeman9
Copy link
Contributor Author

yea it would just be nice to see what this fixes / breaks so we know it's producing valid ones

I will look into it a bit and see what I can find out.

@codeman9
Copy link
Contributor Author

codeman9 commented Aug 31, 2021

From a @kastiglione thread I found: "it's for swiftc to emit diagnostics across module boundaries" and "so as I understand, it's useful to the IDE only indirectly (the IDE displaying the compiler's diagnostics)"

brentleyjones pushed a commit that referenced this pull request Sep 28, 2021
Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule.

PiperOrigin-RevId: 398579438
(cherry picked from commit 4e45e79)

# Conflicts:
#	swift/internal/compiling.bzl

Fixes #496
Closes #523
brentleyjones added a commit that referenced this pull request Sep 29, 2021
Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule.

PiperOrigin-RevId: 398579438
(cherry picked from commit 4e45e79)

# Conflicts:
#	swift/internal/compiling.bzl

Fixes #496
Closes #523

Co-authored-by: Googler <noreply@google.com>
tymurmustafaiev pushed a commit to tymurmustafaiev/rules_swift that referenced this pull request Jul 19, 2023
…elbuild#692)

Declares `.swiftsourceinfo` as an output file of a compile action and threads the file through to be an output of the swift_library rule.

PiperOrigin-RevId: 398579438
(cherry picked from commit 4e45e79)

# Conflicts:
#	swift/internal/compiling.bzl

Fixes bazelbuild#496
Closes bazelbuild#523

Co-authored-by: Googler <noreply@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants