Align macro support with upstream #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
thii
approved these changes
Oct 14, 2024
brentleyjones
force-pushed
the
bj/align-macros-upstream
branch
from
807bd67 to
5d80b50
Compare
PiperOrigin-RevId: 540589258 (cherry picked from commit b114729) Cherry-pick notes: We already added macro support in c9d1f5f. This is just aligning the changes more. Also, I accidentally made `SwiftCompilerPluginInfo` public in cf155fc. This corrects that change by making it internal again. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/align-macros-upstream
branch
from
5d80b50 to
9305c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 540589258
(cherry picked from commit b114729)
Cherry-pick notes: We already added macro support in c9d1f5f. This is just aligning the changes more. Also, I accidentally made
SwiftCompilerPluginInfopublic in cf155fc. This corrects that change by making it internal again.