Add new swift.modular_indexing feature to index explicit PCMs #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 3, 2024
This allows us to index explicit PCMs once they are built and then never again. Currently we only do this for system SDKs as we assume that we already have source code available for other SDKs, but this can be expanded in the future. In addition, make swift.file_prefix_map also remap DEVELOPER_DIR. PiperOrigin-RevId: 478594522
brentleyjones
referenced
this pull request
Oct 3, 2024
Pre Xcode 14 you'll get a warning if this is specified without having indexing enabled: ``` <unknown>:0: warning: -index-unit-output-path is ignored without -index-store-path ``` We can reconsider this in the future (e.g. to automatically set this for Xcode 14+), but for now limit the scope based on the modular indexing feature. PiperOrigin-RevId: 480943677
This allows us to index explicit PCMs once they are built and then never again. Currently we only do this for system SDKs as we assume that we already have source code available for other SDKs, but this can be expanded in the future. In addition, make swift.file_prefix_map also remap DEVELOPER_DIR. PiperOrigin-RevId: 478594522 (cherry picked from commit a5d5c2b) Signed-off-by: Brentley Jones <github@brentleyjones.com>
Pre Xcode 14 you'll get a warning if this is specified without having indexing enabled: ``` <unknown>:0: warning: -index-unit-output-path is ignored without -index-store-path ``` We can reconsider this in the future (e.g. to automatically set this for Xcode 14+), but for now limit the scope based on the modular indexing feature. PiperOrigin-RevId: 480943677 (cherry picked from commit c9b5002) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/swift.modular_indexing
branch
from
9d93662 to
8f871e9
Compare
luispadron
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to index explicit PCMs once they are built and then
never again. Currently we only do this for system SDKs as we assume
that we already have source code available for other SDKs, but this
can be expanded in the future.
In addition, make swift.file_prefix_map also remap DEVELOPER_DIR.
PiperOrigin-RevId: 478594522
(cherry picked from commit a5d5c2b)
Only add "index-unit-output-path" in the output map for modular indexing
Pre Xcode 14 you'll get a warning if this is specified without having indexing enabled:
We can reconsider this in the future (e.g. to automatically set this for Xcode 14+),
but for now limit the scope based on the modular indexing feature.
PiperOrigin-RevId: 480943677
(cherry picked from commit c9b5002)